Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix port typo in example #1322

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Fix port typo in example #1322

merged 2 commits into from
Mar 8, 2019

Conversation

dkess
Copy link
Contributor

@dkess dkess commented Mar 8, 2019

No description provided.

ekohl
ekohl approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it could work if you would like such a set up, but I agree it's not very nice. Would you mind fixing it on line 59 as well to keep it consistent?

@ekohl ekohl changed the title Fix port typo Fix port typo in example Mar 8, 2019
@ekohl ekohl merged commit f1a1fe8 into voxpupuli:master Mar 8, 2019
@ekohl
Copy link
Member

ekohl commented Mar 8, 2019

Thanks!

Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
@ekohl
Merge pull request voxpupuli#1322 from dkess/patch-1
af280d1 
Fix port typo in example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkess @ekohl