Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing some documentation for setting up UDP streams #1333

Merged
merged 3 commits into from
Jun 5, 2019

Conversation

martinrw
Copy link
Contributor

Pull Request (PR) description

The hiera example in the readme file about configuring a udp stream had a few errors.

  • The ports need to have no apostrophes as they are numbers
  • Some colons were missing
  • The appropriate "include" sections don't get added to nginx.conf unless "nginx::stream" is set

This Pull Request (PR) fixes the following issues

n/a

nginx::stream: is required when setting up a stream otherwise the config dirs don't get included in nginx.conf
@dhoppe
Copy link
Member

dhoppe commented Jun 3, 2019

@martinrw Thank you very much for your contribution.

@alexjfisher alexjfisher reopened this Jun 3, 2019
@dhoppe dhoppe merged commit b9b0fe3 into voxpupuli:master Jun 5, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Sep 13, 2019
fixing some documentation for setting up UDP streams
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
fixing some documentation for setting up UDP streams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants