Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct stream mapfile location #1389

Merged
merged 1 commit into from
May 25, 2020
Merged

Use correct stream mapfile location #1389

merged 1 commit into from
May 25, 2020

Conversation

tuxmea
Copy link
Member

@tuxmea tuxmea commented May 14, 2020 •
edited
Loading

Pull Request (PR) description

Location for mapfiles differ if mapfile is loaded in http or stream context.

This Pull Request (PR) fixes the following issues

#1378

Use correct stream mapfile location
08d8345 
Location for mapfiles differ if mapfile is loaded in http or stream context.
@tuxmea tuxmea requested a review from bastelfreak May 14, 2020 07:23
@tuxmea tuxmea closed this May 14, 2020
@tuxmea
Copy link
Member Author

tuxmea commented May 14, 2020 •
edited
Loading

reopen to trigger travis on last force push commit

@tuxmea tuxmea reopened this May 14, 2020
@puppet-community-rangefinder
Copy link

nginx::resource::map is a type

that may have no external impact to Forge modules.

This module is declared in 11 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@tuxmea
Copy link
Member Author

tuxmea commented May 14, 2020

Build errors:

CentOS 7 - Puppet 5 and 6:

 failure: repodata/repomd.xml from passenger: [Errno 256] No more mirrors to try.

  https://oss-binaries.phusionpassenger.com/yum/passenger/el/7/x86_64/repodata/repomd.xml: [Errno -1] repomd.xml signature could not be verified for passenger

@tuxmea tuxmea requested a review from alexjfisher May 21, 2020 11:37
@tuxmea tuxmea closed this May 24, 2020
@tuxmea
Copy link
Member Author

tuxmea commented May 24, 2020

trigger travis

@tuxmea tuxmea reopened this May 24, 2020
@puppet-community-rangefinder
Copy link

nginx::resource::map is a type

that may have no external impact to Forge modules.

This module is declared in 11 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ghoneycutt
Copy link
Member

These errors seem unrelated. +1 to merge.

@tuxmea
Copy link
Member Author

tuxmea commented May 25, 2020

What policy do we (voxpupuli) have in terms of hitting the merge button?
Is the author of a PR allowed to merge after approval or must merge be done by a different person?

@alexjfisher
Copy link
Member

https://voxpupuli.org/docs/reviewing_pr/

ekohl
ekohl approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll admit I've merged my own PRs after that had been approval.

@ekohl ekohl merged commit a2be060 into voxpupuli:master May 25, 2020
@tuxmea tuxmea deleted the stream_mapfiles branch May 25, 2020 13:57
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
@ekohl
Merge pull request voxpupuli#1389 from tuxmea/stream_mapfiles
26365b9 
Use correct stream mapfile location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@ghoneycutt ghoneycutt ghoneycutt approved these changes

@dhoppe dhoppe dhoppe approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak

@alexjfisher alexjfisher Awaiting requested review from alexjfisher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tuxmea @ghoneycutt @alexjfisher @ekohl @dhoppe