Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug_connection events option #1396

Merged
merged 2 commits into from
Aug 30, 2020
Merged

Add debug_connection events option #1396

merged 2 commits into from
Aug 30, 2020

Conversation

juokelis
Copy link

Pull Request (PR) description

Addes a possibility to use debug_connection under events.

This Pull Request (PR) fixes the following issues

n/a

@puppet-community-rangefinder
Copy link

nginx::config is a class

Breaking changes to this file MAY impact these 2 modules (near match):

nginx is a class

Breaking changes to this file WILL impact these 13 modules (exact match):
Breaking changes to this file MAY impact these 32 modules (near match):

This module is declared in 11 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

ekohl
ekohl reviewed Jul 17, 2020
View reviewed changes
templates/conf.d/nginx.conf.erb Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
ekohl
ekohl approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Test failure is unrelated. Do you mind squashing the commits or shall I squash them on merge?

@juokelis
Copy link
Author

Thanks! Test failure is unrelated. Do you mind squashing the commits or shall I squash them on merge?

Done. Thank you!

ekohl
ekohl approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl
Copy link
Member

ekohl commented Jul 17, 2020

Travis is still running. I expect it'll still pass but let's wait for it to complete.

@vox-pupuli-tasks
Copy link

Dear @juokelis, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@juokelis
Copy link
Author

As I can see there's an issue with passenger signature, not with updated code. Or am I wrong? I can see in Travis logs:

Error: Execution of '/usr/bin/yum -d 0 -e 0 -y install passenger' returned 1: Importing GPG key 0xA9F2A55D:
Userid : "https://packagecloud.io/phusion/passenger (https://packagecloud.io/docs#gpg_signing) support@packagecloud.io"
Fingerprint: fd6f dce0 2b2a 3a80 e2c6 e719 f4e6 c567 a9f2 a55d
From : https://packagecloud.io/phusion/passenger/gpgkey

@alexjfisher
Copy link
Member

Closing and reopening PR to restart build.

@alexjfisher alexjfisher reopened this Aug 29, 2020
@puppet-community-rangefinder
Copy link

nginx::config is a class

Breaking changes to this file MAY impact these 2 modules (near match):

nginx is a class

Breaking changes to this file WILL impact these 14 modules (exact match):
Breaking changes to this file MAY impact these 32 modules (near match):

This module is declared in 10 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@alexjfisher alexjfisher added enhancement New feature or request and removed tests-fail labels Aug 29, 2020
alexjfisher
alexjfisher requested changes Aug 29, 2020
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
templates/conf.d/nginx.conf.erb Outdated Show resolved Hide resolved
Vilnius Ramanauskas and others added 2 commits August 30, 2020 10:31
@alexjfisher
Add debug_connection events option
46c6a27
@alexjfisher
Add tests and docs for debug_connections
e9e8768 
`Stdlib::IP::Address` also added to the type alias so that it accepts
IPv6 networks.
@alexjfisher
Copy link
Member

@juokelis Thanks! I've added an extra commit with some tests and will merge when the build goes green.

@alexjfisher alexjfisher merged commit 6323a56 into voxpupuli:master Aug 30, 2020
@juokelis juokelis deleted the debug_connection branch August 30, 2020 11:26
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
@alexjfisher
Merge pull request voxpupuli#1396 from juokelis/debug_connection
c9033fb 
Add debug_connection events option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjfisher alexjfisher alexjfisher approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juokelis @ekohl @alexjfisher