Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables to overwrite fastcgi.conf and uwsgi_params template #1451

Merged
merged 1 commit into from
May 25, 2021

Conversation

TuningYourCode
Copy link
Contributor

Pull Request (PR) description

This PR introduces variables to overwrite the fastcgi.conf and uwsgi_params templates.

This Pull Request (PR) fixes the following issues

Relates to #862

@puppet-community-rangefinder
Copy link

nginx is a class

Breaking changes to this file WILL impact these 14 modules (exact match):
Breaking changes to this file MAY impact these 34 modules (near match):

nginx::resource::location is a type

Breaking changes to this file WILL impact these 9 modules (exact match):
Breaking changes to this file MAY impact these 16 modules (near match):

nginx::resource::server is a type

Breaking changes to this file WILL impact these 13 modules (exact match):
Breaking changes to this file MAY impact these 4 modules (near match):

This module is declared in 9 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@TuningYourCode
Copy link
Contributor Author

Could anybody help with supplying a test? The already existing $conf_template seems to also have no test for the template overwrite only checks for template variables - which we do not have in these templates (yet).

manifests/init.pp Outdated Show resolved Hide resolved
@bastelfreak bastelfreak merged commit 570434f into voxpupuli:master May 25, 2021
@alexjfisher alexjfisher added the enhancement New feature or request label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants