Sort @passenger_cgi_param to make sure generated config file content is stable. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super! Yeah, unordered hashes kinda stink. Thanks for this. |
jfryman
pushed a commit
that referenced
this pull request
Jan 24, 2014
Sort @passenger_cgi_param to make sure generated config file content is stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see a strange issue when I use @passenger_cgi_param in nginx::resource::vhost. The
passenger_set_cgi_parampart in generated nginx site config is keeping changing. It makes nginx service restarted after every puppet agent run.It seems
eachon hash map is not stable. My solution is to get hash keys and sort them to make sure it's stable.