Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add $passenger_pre_start variable #880

Merged
merged 1 commit into from
Sep 26, 2016
Merged

add $passenger_pre_start variable #880

merged 1 commit into from
Sep 26, 2016

Conversation

wyardley
Copy link
Collaborator

passenger_pre_start (unlike other passenger settings that are not directly in the module, and can be easily added with an 'append' directive inside the vhost) has to be outside the scope of the server {} block. If this is too specific, I could alternatively make a different append variable that appends in the vhost file but outside that block.

I believe it might be possible to put it in http {} also, but most examples show it following the server {} block, but outside of its scope.
https://www.phusionpassenger.com/library/config/nginx/reference/#passenger_pre_start

Since the required stdlib version still doesn't seem to have a validate_url function, I just validated that it was a string, rather than trying to come up with a regex that would validate all possible valid URLs.

I added a test, but didn't add a test for the actual validation of parameters (most other params don't seem to have this at present).

@bastelfreak bastelfreak merged commit 65dd5d2 into voxpupuli:master Sep 26, 2016
@wyardley wyardley deleted the feature_passenger_pre_start branch October 27, 2016 17:16
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Sep 13, 2019
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants