Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unmanaged nodesets #884

Merged
merged 1 commit into from Oct 5, 2016
Merged

remove unmanaged nodesets #884

merged 1 commit into from Oct 5, 2016

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Sep 24, 2016

Remove all nodesets which aren't managed in voxpupuli's modulesync_config (https://github.com/voxpupuli/modulesync_config/tree/master/moduleroot/spec/acceptance/nodesets)

This means all will be updated automatically going forward.

Note that until a default.yml is added to modulesync_config, users running acceptance tests will have to specify a nodeset using BEAKER_set= e.g. BEAKER_set=ubuntu-server-1204-x64 bundle exec rake beaker

@3flex
Copy link
Contributor Author

3flex commented Sep 24, 2016

To avoid issues with missing default.yml it might be preferred to wait until voxpupuli/modulesync_config#229 or something like it is merged, and wait for the next module sync.

But given the acceptance tests haven't been run at all for many months at least, impact of merging before that happens will be minimal.

@dhoppe
Copy link
Member

dhoppe commented Sep 29, 2016

We should also remove default.yml, because this file is not managed via module_sync and the user should be able to choose the operating system as he likes. You can not provide Ubuntu as default, if the user prefers CentOS or anything else.

@3flex
Copy link
Contributor Author

3flex commented Oct 5, 2016

@dhoppe since I did removedefault.yml from this repo in this PR, can we merge?

@dhoppe dhoppe merged commit de4e739 into master Oct 5, 2016
@3flex 3flex deleted the cleanup_nodesets branch October 9, 2016 05:31
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Sep 13, 2019
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants