Allow location_allow / location_deny as well in location blocks #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2016
Closed
|
Will try and figure out if there is any more testing I can do for this beyond https://github.com/voxpupuli/puppet-nginx/blob/master/spec/defines/resource_location_spec.rb#L823 |
wyardley
changed the title
wyardley
changed the title
|
Please rebase. |
|
@jyaworski: this was current but had conflicts due to some of my other merged commits. Rebased. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
…tion Allow location_allow / location_deny as well in location blocks
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
…tion Allow location_allow / location_deny as well in location blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #741
I did not add any additional tests here, if anyone has a suggestion of a test that should be added, I can add one.
This also simplifies the syntax a little, will need to verify that the changes work as I expect with all Puppet versions.