Set log directory ownership / permissions explicitly #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wyardley Since you use a different set of user/ group you should use 0750 as mode. Otherwise logging tools like Logstash could have problems accessing the logs. |
|
@dhoppe: you're right, updated config and spec tests to have it default to 0750. |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Set log directory ownership / permissions explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this look sane as a fix for #664? This is one we should definitely try and get right, as it could cause problems if the ownership isn't correct on various platforms.
::nginxas well as::nginx::config? I think with new parameters, it's better not to do that until we work out the exact structural changes.I added
log_modein nginx::config, as I think it's important to have a sane default that's restrictive (0700), but people often do also need to grant group / other permissions on the nginx logdir that are custom. We could make the default 0750 or 0751 if that makes more sense.