Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSpec tests so that they run successfully under docker containers #137

Closed
juniorsysadmin opened this issue May 20, 2015 · 3 comments
Closed

Comments

@juniorsysadmin
Copy link
Member

The RSpec tests can't currently be run on TravisCI with sudo: false as sadly one of the provider tests fail when this is set. Given how slow tests now run on non-docker TravisCI instances, fixing this would without doubt result in an immediate 50% increase in general health and well-being for any PR contributor.

@igalic
Copy link
Contributor

igalic commented May 26, 2015

\o/

@juniorsysadmin
Copy link
Member Author

For those playing at home, the culprit when invoked on TravisCI is:
`
Failures:

  1. Puppet::Type::Package::ProviderNpm when npm packages are installed globally should log and return no packages if JSON isn't output
    Failure/Error: expect(@provider.class.instances).to eq([])
    Mocha::ExpectationError:
    unexpected invocation: Puppet.debug('Warning: npm list --json exited with code 126')
    unsatisfied expectations:
    • expected exactly once, not yet invoked: Puppet.debug(regexp_matches(/npm list.*failure!/))
      `

@juniorsysadmin
Copy link
Member Author

A hack fix has been done in #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants