Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect repo validation for Ubuntu 15.04/15.10 #238

Closed
drkp opened this issue Jul 10, 2016 · 3 comments
Closed

incorrect repo validation for Ubuntu 15.04/15.10 #238

drkp opened this issue Jul 10, 2016 · 3 comments
Labels
bug Something isn't working

Comments

@drkp
Copy link
Contributor

drkp commented Jul 10, 2016

It looks like b8c672d changed the validate_re's for 15.04 and 15.10 to have a trailing x, so they'll only match 4.xx not 4.x. This doesn't seem right...
@bastelfreak
Copy link
Member

Hi @drkp,

thanks for reporting this. Are you able to also provide a patch for it?

drkp added a commit to drkp/puppet-nodejs that referenced this issue Jul 10, 2016
@drkp
Fix repo validation regexps for Ubuntu 15.04/15.10 (voxpupuli#238)
409554c
@drkp
Copy link
Contributor Author

drkp commented Jul 10, 2016

Sure, just submitted #239

@juniorsysadmin juniorsysadmin added the bug Something isn't working label Sep 11, 2016
drkp added a commit to drkp/puppet-nodejs that referenced this issue Nov 8, 2016
@drkp
Fix repo validation regexps for Ubuntu 15.04/15.10 (voxpupuli#238)
1738d15
juniorsysadmin added a commit that referenced this issue Jan 1, 2017
@juniorsysadmin
Merge pull request #239 from drkp/master
634231f 
Fix repo validation regexps for Ubuntu 15.04/15.10 (#238)
@juniorsysadmin
Copy link
Member

Fixed by #239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bastelfreak @drkp @juniorsysadmin