Document that puppetlabs-apt versions less than 2.x are required #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document that this module currently requires puppetlabs-apt versions less than 2.x, and test against 1.8.x
|
Apt is an implicit requirement in metadata.json. I am okay with this change. |
underscorgan
pushed a commit
that referenced
this pull request
Apr 23, 2015
Document that puppetlabs-apt versions less than 2.x are required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppetlabs-apt 2.x changes apt::source parameters substantially. This patch makes it clear that this module will break if puppetlabs-apt 2.x is used currently.
The idea is that this module targets puppetlabs-apt 1.x up to the next tagged release (0.8.x), then this module gets modified to target puppetlabs-apt 2.x-only after this point (eg. puppetlabs-nodejs 0.9.x targets puppetlabs-apt 2.x)