Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stdlib and Puppet version requirements in metadata.json #130

Merged
merged 1 commit into from
May 22, 2015

Conversation

juniorsysadmin
Copy link
Member

Official stdlib docs state that stdlib 2.x is not compatible with Puppet 3.x.
We require Puppet versions 3.4.0 or greater due to #121

@igalic
Copy link
Contributor

igalic commented May 4, 2015

what's up with the test failures?

 1) nodejs when run on Debian release 7.0 with legacy_debian_symlinks set to true the file resource /usr/bin/node should be in the catalog
     Failure/Error: should contain_file('/usr/bin/node')
     Puppet::Error:
       undefined method `ref' for nil:NilClass on node testing-worker-linux-f25aadab-1-20168-linux-8-61003744
     # /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/puppet-3.4.3/lib/puppet/resource/catalog.rb:527:in `block in to_catalog'

@juniorsysadmin
Copy link
Member Author

The test were failing for some reason only on 3.4.0 - I have no idea why. Since the travis.yml has now changed on master, I have rebased and tests on the new Travis CI matrix are now all green.

@juniorsysadmin
Copy link
Member Author

Before this was moved across, tests were okay. This should probably be merged in before the next release is cut. Any objections?

@ffrank
Copy link
Contributor

ffrank commented May 20, 2015

Can you make this into a new PR so that Travis can greenlight it once more? Call me a paranoid nitpick :)

Official stdlib docs state that stdlib 2.x is not compatible with
Puppet 3.x.
We also require Puppet version 3.4.0 or greater due to the use of
contains.
@nibalizer
Copy link
Member

@ffrank why does it need a new PR? I see greens from travis and here: http://planck.nibalizer.com:5000/modules/puppet-community/puppet-nodejs

@ffrank
Copy link
Contributor

ffrank commented May 22, 2015

Rebase apparently did the trick? I'm happy either way 👍

nibalizer added a commit that referenced this pull request May 22, 2015
Fix stdlib and Puppet version requirements in metadata.json
@nibalizer nibalizer merged commit 386f8aa into voxpupuli:master May 22, 2015
@juniorsysadmin juniorsysadmin deleted the fix-deps branch December 26, 2017 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants