Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metadata.json #136

Merged
merged 2 commits into from
May 26, 2015
Merged

Fix metadata.json #136

merged 2 commits into from
May 26, 2015

Conversation

mcanevet
Copy link
Member

No description provided.

nibalizer
nibalizer reviewed May 20, 2015
View reviewed changes
metadata.json
@@ -1,11 +1,11 @@
{
"name": "puppetlabs-nodejs",
"name": "puppetcommunity-nodejs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be puppet.

@nibalizer
Copy link
Member

Sorry. I had the particulars of this wrong.

@daenney
Copy link
Member

daenney commented May 20, 2015

If its now "our" module we should use Github issues and not expect everyone to create a Puppetlabs account and track the issues there. Also makes it easier to link PRs to issues etc.

@mcanevet
Copy link
Member Author

@daenney cool you allow github issues on this module? Or give me the permissions to do it?

@mcanevet
Copy link
Member Author

@daenney issues before migration to Jira appeared...

@mcanevet
Copy link
Member Author

@daenney @nibalizer can we merge this and make a first release in the puppet namespace?

juniorsysadmin
juniorsysadmin reviewed May 20, 2015
View reviewed changes
metadata.json
@@ -1,12 +1,12 @@
{
"name": "puppetlabs-nodejs",
"name": "puppet-nodejs",
"version": "0.8.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the version number be reset?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juniorsysadmin yes, but maybe after merging this PR, juste before releasing a new version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can release a 0.9.0, no need to reset.

@juniorsysadmin
Copy link
Member

Don't forget #130 before the release.

igalic
igalic reviewed May 20, 2015
View reviewed changes
metadata.json
"version": "0.8.0",
"author": "puppetlabs",
"name": "puppet-nodejs",
"version": "0.9.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd suggest we give it a 1.0.0

igalic added a commit that referenced this pull request May 26, 2015
@igalic
Merge pull request #136 from mcanevet/fix/metadata.json
819a521 
Fix metadata.json
@igalic igalic merged commit 819a521 into voxpupuli:master May 26, 2015
@mcanevet mcanevet deleted the fix/metadata.json branch May 26, 2015 17:52
cegeka-jenkins pushed a commit to cegeka/puppet-nodejs that referenced this pull request Oct 23, 2017
@igalic
Merge pull request voxpupuli#136 from mcanevet/fix/metadata.json
5eb4711 
Fix metadata.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcanevet @nibalizer @daenney @juniorsysadmin @igalic