fixing amazon default settings #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. Perhaps leave the previous code in there (with a comment explaining that this is for older versions of Amazon Linux (<2015.03)). Also, if you are able to, can you add the relevant unit tests as well? |
|
readded the test case, fixed also nodesource rpm for amazon linux. |
|
@webratz would you mind squashing the failing tests, please? |
added 2 commits
July 30, 2015 09:13
readding this case for older facter and Amazon Linux Versions fixing repo for newer amazon linux versions adding tests for Amazon Linux 2015.03
* 'master' of github.com:webratz/puppet-nodejs: adding tests for Amazon Linux 2015.03 fixing repo for newer amazon linux versions readding this case for older facter and Amazon Linux Versions fixing amazon default settings
|
squashed alltogether into first commit |
|
duh. that's neither squashed nor… uhm…i don't know what happned there. |
|
that looks indeed weird. i don't know how it happened but i guess we can't revert it easily |
|
@webratz no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon LInux (at least on Version 2015.03) reports its own osfamily as RedHat therefore the old code causes the manifest to fail.
This PR fixes the detection.