Allowed home environment variable to be set #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to: #35 |
|
thanks @hunner |
| it 'the environment variable HOME should be /root' do | ||
| is_expected.to contain_exec('npm_install_express').with({ | ||
| 'environment' => 'HOME=/root', | ||
| }) |
There was a problem hiding this comment.
appears to be normal
There was a problem hiding this comment.
There is an extra space before the } causing it not to line up.
This was fixed in the package provider, but never fixed in the exec the nodejs::npm class was utilizing for installations: Heres a bit of background: Node-gyp expects either HOME or USERPROFILE to be defined in the environment. If it is not set, installation will fail. ``` Error: node-gyp requires that the user's home directory is specified in either of the environmental variables HOME or USERPROFILE ``` Update nodejs_npm_spec.rb Added spec test where the environment variable HOME is defined as '/root' Update nodejs_npm_spec.rb fixed spec test fixed whitespacing issues
nibalizer
added a commit
that referenced
this pull request
Aug 18, 2015
Allowed home environment variable to be set
cegeka-jenkins
pushed a commit
to cegeka/puppet-nodejs
that referenced
this pull request
Oct 23, 2017
Allowed home environment variable to be set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fixed in the package provider, but never fixed in the exec the nodejs::npm class was utilizing for installations:
Heres a bit of background:
Node-gyp expects either HOME or USERPROFILE to be defined in the environment. If it is not set, installation will fail.