Fix repo_url_suffix regex validation #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsde would you mind adding a test to catch that assumption? |
|
@igalic I've added some test. And, bonus, also included tests on repo_url_suffix for redhat-based OS. Previously, there were no such tests for these distros. Let me know if everything is fine |
igalic
added a commit
that referenced
this pull request
Nov 25, 2015
Fix repo_url_suffix regex validation
|
nice! thank you @tsde |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
This PR is linked to #174
I made a small mistake in regex checks for repo_url_suffix. This could lead to $repo_url_suffix not raising an error when wrongly set to 0.10.0 for example (the 0.10 is matched only so validate_re is not failing). This PR fixes that.
Sorry for that ;)