Manage /root/.npmrc #216
Merged
Manage /root/.npmrc #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to specify the _auth config key which cannot be set using 'npm config set _auth'.
|
I'm using Artifactory with an internal NPM registry. Part of that configuration is specifying The README states that the module manages the npmrc, which it does not, until now, though it specifically manages /root/.npmrc. |
| @@ -107,6 +108,12 @@ | |||
| validate_string($npm_package_name) | |||
| } | |||
|
|
|||
| if $npmrc_auth { | |||
| if is_string($npmrc_auth) == false { | |||
There was a problem hiding this comment.
Did this instead of validate_string because I wanted to check for the Puppet::Error and a specific error string which can change quite a bit using validate_string() on different platforms.
|
@jyaworski Thank you! Could you please create a new tagged release with this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to specify the _auth config key which cannot be set
using 'npm config set _auth'.