Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off legacy symlinks for ubuntu 16.04 #317

Merged
merged 1 commit into from
Sep 17, 2017

Conversation

guerremdq
Copy link
Contributor

@guerremdq guerremdq commented Sep 15, 2017

With the New version of NodeJS v6.11.3 puppet brakes the installation on ubuntu 16.04

Content of the node packages.

  • V6.11.2
~$ dpkg -l |grep nodejs
ii  nodejs                              6.11.2-1nodesource1~xenial1                amd64        Node.js event-based server-side javascript engine
~$ dpkg -L nodejs |grep '/usr/bin/'
/usr/bin/nodejs
/usr/bin/npm
  • V6.11.3
~# dpkg -l|grep nodejs
ii  nodejs                       6.11.3-1nodesource1                   amd64        Node.js event-based server-side javascript engine

~# dpkg -L nodejs |grep '/usr/bin/'
/usr/bin/node
/usr/bin/npm

After puppet runs to install nodejs the node binary is a broken link.

~# ls -ltra /usr/bin/node /usr/bin/nodejs  /etc/alternatives/nodejs
lrwxrwxrwx 1 root root 24 Sep 15 09:41 /usr/bin/nodejs -> /etc/alternatives/nodejs
lrwxrwxrwx 1 root root 13 Sep 15 09:41 /etc/alternatives/nodejs -> /usr/bin/node
lrwxrwxrwx 1 root root 15 Sep 15 09:41 /usr/bin/node -> /usr/bin/nodejs

With the New version of NodeJS v6.11.3 puppet brakes the installation on ubuntu 16.04

* Content of the node packages.
V6.11.2
```
~$ dpkg -l |grep nodejs
ii  nodejs                              6.11.2-1nodesource1~xenial1                amd64        Node.js event-based server-side javascript engine
~$ dpkg -L nodejs |grep '/usr/bin/'
/usr/bin/nodejs
/usr/bin/npm
```
V6.11.3
```
~# dpkg -l|grep nodejs
ii  nodejs                       6.11.3-1nodesource1                   amd64        Node.js event-based server-side javascript engine

~# dpkg -L nodejs |grep '/usr/bin/'
/usr/bin/node
/usr/bin/npm
```

After puppet runs to install nodejs the node binary is a broken link. 
```
~# ls -ltra /usr/bin/node /usr/bin/nodejs  /etc/alternatives/nodejs
lrwxrwxrwx 1 root root 24 Sep 15 09:41 /usr/bin/nodejs -> /etc/alternatives/nodejs
lrwxrwxrwx 1 root root 13 Sep 15 09:41 /etc/alternatives/nodejs -> /usr/bin/node
lrwxrwxrwx 1 root root 15 Sep 15 09:41 /usr/bin/node -> /usr/bin/nodejs
```
@bastelfreak
Copy link
Member

Hi @guerremdq, thanks for this PR! Travis should an unrelated error which we fixed in the master branch. I rebased your branch against latest master. It should turn green now.

@bastelfreak bastelfreak merged commit c67c992 into voxpupuli:master Sep 17, 2017
@bastelfreak bastelfreak added the bug Something isn't working label Sep 17, 2017
@guerremdq guerremdq deleted the patch-1 branch September 18, 2017 06:36
@wyardley
Copy link
Contributor

commented in #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatible bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants