Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo_release parameter #349

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

juniorsysadmin
Copy link
Member

Some Debian-derived distributions use their own lsbdistcodename, but work fine when using Debian packages. Add a repo_release parameter to allow users to specify an apt::source release value which matches their Debian family and therefore allow management of the NodeSource repository on those systems.

Supersedes #342

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Dec 25, 2017
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is pretty much written by @fnoop it'd be good to use git commit --author and give him the proper credits.

@juniorsysadmin
Copy link
Member Author

Given this is pretty much written by @fnoop it'd be good to use git commit --author and give him the proper credits.

Yeah, I forgot to mention their handle here as well. @fnoop Okay to replace this with you as the commit author?

@juniorsysadmin
Copy link
Member Author

@fnoop Okay to replace this with you as the commit author?

@fnoop
Copy link
Contributor

fnoop commented Jan 4, 2018

@juniorsysadmin Really sorry for delay this has been on my todo list but never quite made the top yet! Yes please do whatever you want, I'm not bothered about attribution to me, just to improve the code.

Some Debian-derived distributions use their own lsbdistcodename, but
work fine when using Debian packages. Add a repo_release parameter
to allow users to specify an apt::source release value which matches
their Debian family and therefore allow management of the NodeSource
repository on those systems.
@juniorsysadmin
Copy link
Member Author

@fnoop Okay to replace this with you as the commit author?

Done

@juniorsysadmin juniorsysadmin merged commit 2f7a4d5 into voxpupuli:master Jan 4, 2018
@juniorsysadmin juniorsysadmin deleted the repo-release branch January 4, 2018 12:53
@fnoop
Copy link
Contributor

fnoop commented Jan 4, 2018

Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants