Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow puppetlabs/stdlib 5.x, replace chocolatey-chocolatey with puppetlabs-chocolatey #378

Merged
merged 3 commits into from
Aug 30, 2018

Conversation

bastelfreak
Copy link
Member

@bastelfreak bastelfreak commented Aug 26, 2018

  • Allow puppetlabs/stdlib 5.x
  • Replace chocolatey-chocolatey references with puppetlabs-chocolatey since the latter appears to be maintained.
  • Comment out gentoo-portage and puppetlabs-chocolatey entries for Beaker acceptance tests, since we currently do not run Beaker tests on Windows or Gentoo.
  • Allow a newer version of puppetlabs-apt to be used for Beaker acceptance tests, since it allows the use of a newer puppetlabs-stdlib version.

@juniorsysadmin juniorsysadmin added enhancement New feature or request tests-fail labels Aug 27, 2018
@juniorsysadmin juniorsysadmin changed the title allow puppetlabs/stdlib 5.x Allow puppetlabs/stdlib 5.x, use puppetlabs-chocolatey Aug 30, 2018
@juniorsysadmin juniorsysadmin changed the title Allow puppetlabs/stdlib 5.x, use puppetlabs-chocolatey Allow puppetlabs/stdlib 5.x, replace chocolatey-chocolatey with puppetlabs-chocolatey Aug 30, 2018
@juniorsysadmin
Copy link
Member

juniorsysadmin commented Aug 30, 2018

puppetlabs-chocolatey is somewhat maintained, chocolatey-chocolatey is not.
stdlib bump: puppetlabs/puppetlabs-chocolatey#114

- Replace chocolatey-chocolatey references with puppetlabs-chocolatey
  since the latter appears to be maintained.
- Comment out gentoo-portage and puppetlabs-chocolatey entries for
  Beaker acceptance tests, since we currently do not run Beaker tests on
  Windows or Gentoo.
- Allow a newer version of puppetlabs-apt to be used for Beaker
  acceptance tests, since it allows the use of a newer puppetlabs-stdlib
  version.
@bastelfreak bastelfreak added backwards-incompatible and removed enhancement New feature or request tests-fail labels Aug 30, 2018
@bastelfreak bastelfreak merged commit 7284cda into master Aug 30, 2018
@bastelfreak bastelfreak deleted the stdlib branch August 30, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants