Fix global_config_entry dependency on NPM when using nodesource repo #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiebe
force-pushed
the
global_config_entry-fix-npm-dependency
branch
from
c8ff913
to
6ed1304
Compare
|
Not sure why the CI build fails, doesn't seem to be because of my change |
|
@wiebe thanks for the PR. Can you take a look at the used email address in the commit? It isn't associated with your github account. Please also add a test for this change. |
Signed-off-by: Wiebe Verweij <wiebe.verweij@moxio.com>
wiebe
force-pushed
the
global_config_entry-fix-npm-dependency
branch
2 times, most recently
from
1fb2bfc
to
22aadce
Compare
Signed-off-by: Wiebe Verweij <wiebe.verweij@moxio.com>
wiebe
force-pushed
the
global_config_entry-fix-npm-dependency
branch
from
22aadce
to
7c774e9
Compare
|
My email address should be added to this account now. I rebased and also added tests, everything is green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This fixes the npm_config exec in the global_config_entry class not having a dependency on the package that installs NPM when using the nodesource class.
This Pull Request (PR) fixes the following issues
#404