source_labels and module must be unquoted

[yackushevas]

for example source_labels:

bad:

 relabel_configs:
  - source_labels: "['__meta_consul_service']"
    regex: "(.*)"
    target_label: service
    replacement: "$1"

good:

 relabel_configs:
  - source_labels: ['__meta_consul_service']
    regex: "(.*)"
    target_label: service
    replacement: "$1"

and blackbox_exporter:

bad:

- job_name: http_check
  metrics_path: "/probe"
  params:
    module: "[http_2xx]"

good:

- job_name: http_check
  metrics_path: "/probe"
  params:
    module: [http_2xx]

[bastelfreak]

Hi @yackushevas, thanks for the PR. The change looks a bit cryptic. Can you add a test that verifies the correct behavior?

[yackushevas]

#98
same thing, but for prometheus 2.x

[bastelfreak]

Hi,
I'm going to close this PR. This got already implemented.

commit b81faa0af76ffbaf97591fdbd7e848fa0bf995e3
Author: Sebastian Rakel <sebastian@devunit.eu>
Date:   Mon Jun 18 23:19:07 2018 +0200

    Remove double quotes from source_labels value with gsub
    
    The value in source_labels have to be without quotes, but sometimes you
    have to use brackets in the value and puppet surrounds it with double
    quotes.
    
    So we need to replace the double quotes with nothing in the template

diff --git a/templates/prometheus.yaml.erb b/templates/prometheus.yaml.erb
index b59941a..483c475 100644
--- a/templates/prometheus.yaml.erb
+++ b/templates/prometheus.yaml.erb
@@ -22,7 +22,7 @@ if @prometheus_v2
 end
  -%>
 <%= if @prometheus_v2
-full_config.to_yaml
+full_config.to_yaml().gsub(/source_labels: ".+?"/) { |x| x.gsub('"', '') }
 else
 full_config.to_yaml(options = {:line_width => -1}).gsub(/source_labels: ".+?"/) { |x| x.gsub('"', '') }
 end