fix sysv init scripts #502
Conversation
kubicgruenfeld
force-pushed
the
fix-sysv-init-centos6
branch
from
7b6cd8c
to
a840120
Compare
kubicgruenfeld
changed the title
kubicgruenfeld
force-pushed
the
fix-sysv-init-centos6
branch
from
a840120
to
aaf6046
Compare
|
I tried at first to reenable the centos 6 tests, but since it will be EOL in a few days i skipped it. they need a lot of work to be feasible again. Nevertheless there are a few supported sysv-init systems out there which would profit from this fix, so i am not sure how to proceed. I did let the tests deactivated for now for centos 6. |
| -web.console.templates=/usr/local/share/prometheus/consoles \ | ||
| -web.console.libraries=/usr/local/share/prometheus/console_libraries \ | ||
| -storage.local.path=/var/lib/prometheus \ | ||
| -storage.local.retention=360h \ | ||
| >> "$LOG_FILE" & | ||
| >> '$LOG_FILE' 2>&1 &" |
There was a problem hiding this comment.
can you explain what this actually fixes? support paths with whitespace?
There was a problem hiding this comment.
Hi, without the additional double quotes parent startup processes remain after startup and logfiles are touched as root.
e.g.
`
/bin/bash /etc/init.d/prometheus restart (root)
\_ runuser -s /bin/bash prometheus -c ulimit -S -c 0 >/dev/null ... (root)
\_ bash -c ulimit -S -c 0 >/dev/null 2>&1 ; /usr/local/bin/prometheus --config.file... (prometheus)
\_ /usr/local/bin/prometheus --config.file=/etc/prometheus/prometheus.yaml --web.console.... (prometheus)
`
compared to
493 56754 6.0 0.0 774908 53652 ? Sl 09:18 0:00 /usr/local/bin/prometheus --config.file=/etc/prometheus/prometheus.yaml --web.console.templates=/usr/local/share/prometheus/consoles --web.console.libraries=/usr/local/share/prometheus/console_libraries --st
bastelfreak
added
bug
fix sysv init scripts
Pull Request (PR) description
This PR fixes the sysv-init-scripts for centos 6. Which was already tried in #294
This Pull Request (PR) fixes the following issues
Fixes #293