Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation wrong on SSL #94

Closed
jhg03a opened this issue Nov 30, 2015 · 4 comments
Closed

Documentation wrong on SSL #94

jhg03a opened this issue Nov 30, 2015 · 4 comments

Comments

@jhg03a
Copy link

jhg03a commented Nov 30, 2015

The frontpage references the parameter "puppetdb_ssl". It was replaced with "puppetdb_ssl_verify". At the same time it appears the type was changed from string to bool. So there isn't a way any longer to specify the CA for the puppetmaster.
@igalic
Copy link
Contributor

igalic commented Dec 2, 2015

@jhg03a any chance you can provide a patch?

@jhg03a
Copy link
Author

jhg03a commented Dec 2, 2015

It's actually really confusing. Digging deeper into the python, it appears that the SSL_VERIFY parameter to the puppetdb connection library actually does take a string that points the the CA cert. I'm not sure what a value of true does.

@ryno75
Copy link

ryno75 commented Feb 4, 2016

Indeed... it should be PUPPETDB_SSL_VERIFY (https://github.com/voxpupuli/puppetboard/blob/master/README.rst#id16). And it should support bool AND string values. This was changed in 6b95a6a and breaks functionality.
I am going to submit a patch.

ryno75 pushed a commit to ryno75/puppet-module-puppetboard that referenced this issue Feb 4, 2016
Fixing what was broken in: 6b95a6a
0ebb5a4 
This should resolve the following issues:
voxpupuli#94
voxpupuli#65 (not 100% sure on this one)
@ryno75 ryno75 mentioned this issue Feb 4, 2016
Merged
@igalic igalic closed this as completed Mar 9, 2016
@igalic
Copy link
Contributor

igalic commented Mar 9, 2016

fixed in #99

@apeeters apeeters mentioned this issue Oct 27, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@igalic @ryno75 @jhg03a