Fixing $bitbucket_secret datatype as it should be Optional[String] ra…
…ther than String
Merge pull request #2 from venushka/bitbucket-webhook-secret
Bitbucket webhook secret
Merge pull request #470 from Dan33l/acceptance_run_in_parallel
Acceptance tests run requests in parallel commented
Merge pull request #478 from voxpupuli/modulesync
modulesync 2.4.0
Merge branch 'master' of https://github.com/voxpupuli/puppet-r10k int…
…o bitbucket-webhook-secret
Merge pull request #464 from venushka/bitbucket-webhook-secret
Adding BitBucket Server secret support.
Remove Gentoo/portage related code as is it not supported.
The module already does not support Gentoo and the portage code is no longer maintained.
Merge pull request #480 from ghoneycutt/bye_bye_gentoo
Remove Gentoo/portage related code as is it not supported.
* The PROXY.md file is not shown on the forge * The `doc/` directory is used by puppet-strings * The information in the file is outdated as the bug in rubygems has been fixed a long time ago
Merge pull request #483 from dhoppe/bump_dependency
Allow puppetlabs/inifile 3.x
Replace exec with Open3.capture3
The deploy and deploy_module methods are already running in a detached forked process, and therefore running the command in the background is redundant. Additionally, by running the command in the background, we lose the ability to capture the exit code, and assume it always succeeds. Running the command in-band additionally allows us to correctly call the slack and rocketchat notifiers, which previously were silenced.
Call generate_types after notifiers
When generate_types is called before the slack/rocketchat notifiers, it causes the chat notifications to be in reverse order, since the generate_types command will also send its own notifications. By calling generate_types after the chat notifiers, the messages appear in the correct order in chat.
Revert chat status code back to 200
Since the chat notifiers are the only thing that actually uses this value (because the deploy and deploy_module methods are run in detached forked processes), the actual value doesn't really matter. There are check in the notify_* methods that check for either a 200 or 500 value, so values passed in should be one of these two values. Keeping the chat status codes at 202 results in broken chat messages, since the color and attachment are not defined.
Return 202 HTTP status from payload and module endpoints
Since the deploy and deploy_module methods are now detached forked processes, their return codes and output are no longer returned automatically to the payload and module endpoints, and we must manually define a return value for them. Since the work has been sent off to an out-of-band process at the time the webhook call returns, a 202 response is acceptable.
Update chat messages to be more accurate for the operation
Since the generate_types method defines an :environment key rather than a :module or :branch, the target value is not defined. We fix that by looking for an :environment key and setting target. Additionally, the phrasing is not valid for generating types, so the phrasing has been updated to better reflect what actually happened.
stdlib 6.0.0 is due to be released soon. This module has already dropped support for puppet 4 and/or doesn't use the updated stdlib `merge` function. See https://github.com/puppetlabs/puppetlabs-stdlib/blob/217068f97edd2396ce37ac8c1bd7e23da621d6be/CHANGELOG.md#supported-release-600
Merge pull request #486 from alexjfisher/update_stdlib_dependency
Allow `puppetlabs/stdlib` 6.x
Merge pull request #484 from dhoppe/patch-1
Convert mocha to rspec-mocks
Merge pull request #482 from voxpupuli/modulesync
modulesync 2.7.0 and drop puppet 4
Merge pull request #487 from dhoppe/add_proxy
Add support for proxy settings
Merge pull request #485 from 0x6d617474/webhook_improvements
Webhook improvements
Merge pull request #489 from dhoppe/fix_provider
Remove support for providers yum, zypper
The configuration file for the webhook config writes values that begin with colons (:) as symbols rather than strings, to allow for calculated values. Since slack emoji names follow the pattern of `:name:`, they are written as symbols instead of strings, and the resulting config file breaks the webhook service. This change simply requires slack icons to be entered without the wrapping colons, and adds them back just before sending to Slack. Where previously the ocean icon would be written as `:ocean:` in the webhook_slack_icon parameter, now it would be written as `ocean`.
Merge pull request #495 from 0x6d617474/slack_icon_fix
Wrap slack_icon with colons
Merge pull request #493 from voxpupuli/rnelson0-patch-1
Release 7.0.0