Allow empty unixsocket(perm) #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dan33l
reviewed
Nov 27, 2019
| Stdlib::Absolutepath $unixsocket = '/var/run/redis/redis.sock', | ||
| Stdlib::Filemode $unixsocketperm = '0755', | ||
| Variant[Stdlib::Absolutepath, Enum['']] $unixsocket = '/var/run/redis/redis.sock', | ||
| Variant[Stdlib::Filemode, Enum['']] $unixsocketperm = '0755', |
There was a problem hiding this comment.
Previously the template allowed it.
There was a problem hiding this comment.
I see only one use case , let the default umask manage the perm of the file.
Bah ... not sure it is useful, but why not.
502ff38 tightened the data types, but too much. It's valid not to bind on a unix socket and the template allowed this.
ekohl
force-pushed
the
empty-unixsocket
branch
from
5bb7823
to
9d26031
Compare
|
How about this version? |
bastelfreak
approved these changes
Nov 27, 2019
Dan33l
approved these changes
Nov 27, 2019
|
@amoralej mind having a look? |
cegeka-jenkins
pushed a commit
to cegeka/puppet-redis
that referenced
this pull request
Feb 16, 2021
Allow empty unixsocket(perm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
502ff38 tightened the data types, but too much. It's valid not to bind on a unix socket and the template allowed this.