Modulesync 2.9.0 / Make disable_unhide Optional, convert params to boolean and small fixes
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove erronious quotes.
At least on latest Redhat packages from EPEL6/7 this is no longer a valid option. Fixes `Unknown configuration file option: DISABLE_UNHIDE=0`
When a URL is given, it gets added to `mirrors.dat`. This parameter can be used in conjunction with `update_mirrors` and `mirrors_mode`.
|
Getting smaller commits out of this with working tests is tricky because many of them depend on each other. Let me know what your idea is. |
alexjfisher
reviewed
Dec 20, 2019
alexjfisher
reviewed
Dec 20, 2019
|
Other than a couple of nitpicks/typos, this looks great! Since it contains so much, maybe we should just update the PR title to 'Migrate to Voxpupuli' and add a commit to update the metadata? Then open a release-summary issue to explain the migration. |
alexjfisher
approved these changes
Dec 20, 2019
In our params.pp we define a bunch of variables. On a long point of view we want to migrate to puppet-strings documentation and data in modules. puppet-strings can get default values for variables, but only if they are directly documented in the class. This PR will help us to realize this.
rkhunter fails if no PATH environment variable is available.
bastelfreak
force-pushed
the
modulesync
branch
from
33cb020
to
c36b218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.