New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rsyslog Action Data Types and Queue Options #106

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
5 participants
@dhollinger
Copy link
Member

dhollinger commented Dec 2, 2018

No description provided.

@dhollinger dhollinger force-pushed the dhollinger:action_data_type branch from b93d18d to 98850db Dec 3, 2018

String[1] => Struct[{
type => Rsyslog::Action_type,
facility => Optional[String[1]],
queue_config => Optional[Rsyslog::Queue_options],

This comment has been minimized.

@dhollinger

dhollinger Dec 3, 2018

Author Member

In order to implement, this will require that a breaking change PR is submitted, but this PR itself does not break any existing functionality

Show resolved Hide resolved types/queue_options.pp Outdated

@dhollinger dhollinger force-pushed the dhollinger:action_data_type branch from 43e58d8 to c26d243 Dec 4, 2018

@dhollinger dhollinger requested review from alexjfisher , bastelfreak and ekohl Dec 4, 2018

@dhollinger dhollinger changed the title WIP: Initial commit with queue options and omfile WIP: Rsyslog Action Data Types and Queue Options Dec 4, 2018

Show resolved Hide resolved types/actions/omfwd.pp Outdated
@Dan33l

Dan33l approved these changes Dec 4, 2018

Copy link
Member

Dan33l left a comment

LGTM

@dhollinger dhollinger force-pushed the dhollinger:action_data_type branch 4 times, most recently from e9ce61c to 575307e Dec 5, 2018

Show resolved Hide resolved types/actions/ommail.pp Outdated
@ekohl
Copy link
Member

ekohl left a comment

It may be good to write some tests, especially for the regexes.

Show resolved Hide resolved types/actions/omfwd.pp Outdated
Show resolved Hide resolved types/actions/omfwd.pp Outdated
Show resolved Hide resolved types/actions/ommail.pp Outdated
Show resolved Hide resolved types/actions/omelasticsearch.pp Outdated

@dhollinger dhollinger force-pushed the dhollinger:action_data_type branch from cbb2cee to 24b3008 Dec 6, 2018

@dhollinger dhollinger force-pushed the dhollinger:action_data_type branch 6 times, most recently from d6fbe71 to 24fb596 Dec 14, 2018

@dhollinger dhollinger force-pushed the dhollinger:action_data_type branch from e11ae44 to 90fc265 Jan 8, 2019

@dhollinger dhollinger removed the needs-tests label Jan 8, 2019

@dhollinger dhollinger changed the title WIP: Rsyslog Action Data Types and Queue Options Rsyslog Action Data Types and Queue Options Jan 8, 2019

@dhollinger dhollinger force-pushed the dhollinger:action_data_type branch from 90fc265 to 9de9d11 Jan 8, 2019

Add new data types for Rsyslog Actions
Added nested custom data types for Rsyslog actions. This includes the
output module names, output module parameters, action parameters, and
queue parameters.

Included are unit tests for all as well. This is NOT implemented in the
puppet code yet. That will be done as part of the 4.0.0 work

@dhollinger dhollinger force-pushed the dhollinger:action_data_type branch from 9de9d11 to f383008 Jan 8, 2019

@dhollinger dhollinger merged commit 1669c6f into voxpupuli:master Jan 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dhollinger dhollinger deleted the dhollinger:action_data_type branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment