Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue-104 - No Hiera support #128

Merged
merged 5 commits into from Nov 7, 2016
Merged

Fixes Issue-104 - No Hiera support #128

merged 5 commits into from Nov 7, 2016

Conversation

ryayon
Copy link
Contributor

@ryayon ryayon commented Nov 4, 2016

Hiera hash are managed only if they exist

  • hiera lookups outside of the variables part of the manifest.

Hiera hash are managed only if they exist 
+ hiera lookups outside of the variables part of the manifest.
@ryayon ryayon mentioned this pull request Nov 4, 2016
@ryayon
Copy link
Contributor Author

ryayon commented Nov 4, 2016

Multiples commit are due to the fact I don't have ssh access to GitHub from my office => I commit from GitHub WebUI directly.

$selinux_booleans = hiera('selinux_booleans', undef)
$selinux_modules = hiera('selinux_modules', undef)
$selinux_fcontexts = hiera('selinux_fcontexts', undef)
$selinux_ports = hiera('selinux_ports', undef)
Copy link
Member

@jyaworski jyaworski Nov 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these all be prefixed with selinux:: in the hiera key?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right (I didn't check it in the README file)
By the way, I also forgot the permissive defined type which I just added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can use Git only through the GitHub WebUI.
That's the reason of the multiple commits and useless lints.

@jyaworski jyaworski merged commit 4b9bf38 into voxpupuli:master Nov 7, 2016
EmRowlands pushed a commit to EmRowlands/puppet-selinux that referenced this pull request Mar 29, 2023
* Fixes Issue-104 - No Hiera support

Hiera hash are managed only if they exist 
+ hiera lookups outside of the variables part of the manifest.

* Puppet lint fix

https://travis-ci.org/voxpupuli/puppet-selinux/jobs/173201284

* Another lint fix

* Fix following @jyaworski comment

* Puppet lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants