Gemfile

@@ -11,7 +11,8 @@ group :development, :unit_tests do
   gem 'json_pure', '~> 1.8',               :require => false if RUBY_VERSION =~ /^1\.8/
   gem 'json_pure', '<= 2.0.1',             :require => false if RUBY_VERSION =~ /^1\.9/
   gem 'json_pure',                         :require => false if RUBY_VERSION =~ /^2\./
-  gem 'metadata-json-lint', '>= 0.0.4',    :require => false
+  gem 'metadata-json-lint', '< 1.2.0',     :require => false if RUBY_VERSION =~ /^1\./
+  gem 'metadata-json-lint',                :require => false if RUBY_VERSION =~ /^2\./
   gem 'semantic_puppet', '0.1.3',          :require => false if RUBY_VERSION =~ /^1\./
   gem 'semantic_puppet',                   :require => false if RUBY_VERSION =~ /^2\./
   gem 'puppet-lint-unquoted_string-check', :require => false

manifests/init.pp

@@ -14,19 +14,19 @@
 #   Default: [ udp:127.0.0.1:162, udp6:[::1]:162 ]
 #
 # [*ro_community*]
-#   Read-only (RO) community string or array for snmptrap daemon.
+#   Read-only (RO) community string or array for agent and snmptrap daemon.
 #   Default: public
 #
 # [*ro_community6*]
-#   Read-only (RO) community string or array for IPv6.
+#   Read-only (RO) community string or array for IPv6 agent.
 #   Default: public
 #
 # [*rw_community*]
-#   Read-write (RW) community string or array.
+#   Read-write (RW) community string or array agent.
 #   Default: none
 #
 # [*rw_community6*]
-#   Read-write (RW) community string or array for IPv6.
+#   Read-write (RW) community string or array for IPv6 agent.
 #   Default: none
 #
 # [*ro_network*]

metadata.json

@@ -1,6 +1,6 @@
 {
   "name": "razorsedge-snmp",
-  "version": "3.8.0",
+  "version": "3.8.1",
   "author": "razorsedge",
   "summary": "Simple Network Management Protocol is for monitoring network and computer equipment. Net-SNMP implements v1, v2c, and v3 on both IPv4 and IPv6.",
   "license": "Apache-2.0",

spec/classes/snmp_init_spec.rb

@@ -958,6 +958,12 @@
           'rocommunity b 127.0.0.2',
         ])
       end
+      it 'should contain File[snmptrapd.conf] with contents "a" and "b"' do
+        verify_contents(catalogue, 'snmptrapd.conf', [
+          'authCommunity log,execute,net a',
+          'authCommunity log,execute,net b',
+        ])
+      end
     end
 
     describe 'master => true' do

templates/snmptrapd.conf.erb

@@ -13,7 +13,9 @@ doNotLogTraps <%= @do_not_log_traps %>
 ################################################################################
 # ACCESS CONTROL
 
-authCommunity log,execute,net <%= @ro_community %>
+<%- [*@ro_community].compact.each do |c| -%>
+authCommunity log,execute,net <%= c %>
+<%- end -%>
 disableAuthorization <%= @disable_authorization %>
 
 ################################################################################