New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Puppet 5 from master, don't set app_management #72

Merged
merged 2 commits into from Feb 5, 2017

Conversation

Projects
None yet
2 participants
@domcleal
Member

domcleal commented Feb 4, 2017

Fixes two failures under Puppet 5.0.0 from master.

master test on Travis CI will fail until the version number is incremented in puppetlabs/puppet#5603.

domcleal added some commits Feb 3, 2017

Test with Puppet master and 4.9.x
Fixes tests for an error string changed in puppetlabs/puppet@efcdf58.
Don't set app_management on Puppet 5, default setting to true
On 5.x, the Puppet setting issues a deprecation warning causing failures
due to the warning, so avoid setting it. The puppet-syntax setting now
defaults to `true` under Puppet 5 and raises an error if a user tries to
disable it.
@rjw1

rjw1 approved these changes Feb 4, 2017

This all looks good.

@domcleal domcleal merged commit 4764089 into voxpupuli:master Feb 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment