Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Assign repo->package even when manage_repo=false on Debian+Re… #148

Merged
merged 5 commits into from Sep 2, 2020
Merged

Conversation

danielsreichenbach
Copy link

Pull Request (PR) description

This changes the repository installation to retain the relation between package repository and package even when the repository is not managed by the module.

This Pull Request (PR) fixes the following issues

This fixes use issues caused by missing dependency when e.g. using other modules to handle InfluxData packages like InfluxDB, Chronograf or Kapacitor and Telegraf is not managing the repository itself.

@vox-pupuli-tasks
Copy link

Dear @danielsreichenbach, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

manifests/service.pp Outdated Show resolved Hide resolved
@bastelfreak bastelfreak added the needs-feedback Further information is requested label Aug 19, 2020
@Woth-Ursula
Copy link
Contributor

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?

The CI failures contain errors/warning like below. They were already in the module and do not belong to our changes.
Is it ok when I fix such things?

manifests/install.pp:76:manifest_whitespace_closing_brace_before:ERROR:there should be a single space or newline before a closing brace manifests/install.pp:62:manifest_whitespace_two_empty_lines:ERROR:there should be no two consecutive empty lines manifests/install.pp:39:strict_indent:WARNING:indent should be 10 chars and is 12

@bastelfreak
Copy link
Member

hi, sorry for the trouble! I fixed those in #151. can you please rebase?

@bastelfreak bastelfreak added bug Something isn't working and removed needs-feedback Further information is requested tests-fail labels Aug 26, 2020
@bastelfreak
Copy link
Member

thanks for the updates. Can you add unit tests to ensure the ordering is now correct?

@Woth-Ursula
Copy link
Contributor

Added some specs. Hope they meet your expectations.

@bastelfreak
Copy link
Member

thanks for the work!

@bastelfreak bastelfreak merged commit 7e31246 into voxpupuli:master Sep 2, 2020
@danielsreichenbach danielsreichenbach deleted the repo-dependency branch September 3, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants