Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLES support #150

Merged
merged 1 commit into from
Aug 22, 2020
Merged

SLES support #150

merged 1 commit into from
Aug 22, 2020

Conversation

tuxmea
Copy link
Member

@tuxmea tuxmea commented Aug 20, 2020

Pull Request (PR) description

Add support for SLES via archive

This Pull Request (PR) fixes the following issues

n/a

@tuxmea tuxmea force-pushed the sles_support branch 2 times, most recently from 4ff06a4 to c3d382d Compare August 21, 2020 12:34
@tuxmea tuxmea requested a review from dhoppe August 21, 2020 13:08
@alexjfisher alexjfisher added the enhancement New feature or request label Aug 21, 2020
Copy link
Member

@alexjfisher alexjfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module has some acceptance tests. Perhaps we could turn them on for SUSE too now?

@bastelfreak
Copy link
Member

at least back in the days, there were no suitable docker images for suse/sles so we abandoned the idea. I don't know if that works now. I would already be happy with unit tests.

@alexjfisher
Copy link
Member

at least back in the days, there were no suitable docker images for suse/sles so we abandoned the idea. I don't know if that works now. I would already be happy with unit tests.

oh, that's a shame. I've no idea how compatible opensuse images would be or if there's even a version 12 one available.

@alexjfisher alexjfisher merged commit 80a3bcd into voxpupuli:master Aug 22, 2020
@tuxmea tuxmea deleted the sles_support branch August 22, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants