Add Optional to config_file_mode and config_folder_mode params on windows #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Oct 17, 2020
bastelfreak
reviewed
Oct 17, 2020
.puppet-lint.rc
Outdated
| @@ -0,0 +1 @@ | |||
| --relative | |||
There was a problem hiding this comment.
can you explain why you changed this? It should not be required to run the tests.
There was a problem hiding this comment.
When I tried to git commit, puppet-lint was executed in pre-commit and it failed.
Without this fix, I couldn't git commit, so I added it.
~/jkkitakita/puppet-telegraf master +1 ❯ git commit -m "hoge"
Running pre-commit hooks
Check for trailing whitespace....................[TrailingWhitespace] OK
Runs puppet-lint on modified files only..................[PuppetLint] FAILED
Errors on lines you didn't modify:
jkkitakita/puppet-telegraf/manifests/params.pp:5:7:ERROR: telegraf::params not in autoload module layout (autoloader_layout)
✗ One or more pre-commit hooks failed
|
@kenyon @bastelfreak |
kenyon
approved these changes
Nov 14, 2020
|
Looks like this was approved, could someone merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
config_file_modeandconfig_folder_modeparams on windowsThis Pull Request (PR) fixes the following issues
Fixes #155