move relationship between package and repo into code block where repo is managed #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this pull request be merged and released, please? |
The relationship specifications were incorrectly outside of the "if $manage_repo" block. Also the tests should have been failing because of that, but the tests were made to artificially pass. This commit fixes the tests and the Puppet code. Co-authored-by: Luke Bigum <Luke.Bigum@lmax.com>
|
This was also a problem with the Debian part of the code. I've now fixed the tests and the code. |
Closed
bastelfreak
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This patch moves the relationship between the
Yumrepoand thePackageresources into the same conditional block of where theYumrepois created. Thus it doesn't assume there's always aYumrepo[influxdata]in the catalog, even ifmanage_repo=>false.