make sure the ensure absent works with package install #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe80
force-pushed
the
feature/ensure_remove
branch
2 times, most recently
from
d5f5781
to
7ec283d
Compare
bastelfreak
reviewed
May 7, 2021
|
@fe80 thanks for the PR. Can you please add a unit test for the change? |
fe80
force-pushed
the
feature/ensure_remove
branch
from
12e11c9
to
ebd42ce
Compare
|
done I had output spec (new file) on a separate commit :) |
|
thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add ensure absent works for package installation.
I don't had this feature for the archive installation (maybe on a separated commit ?)
This Pull Request (PR) fixes the following issues
n/a