Add FreeBSD support, using telegraf as installed by pkg(8) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please also add freebsd to https://github.com/voxpupuli/puppet-telegraf/blob/master/metadata.json |
bastelfreak
reviewed
Jan 13, 2022
metadata.json
Outdated
| @@ -74,6 +74,13 @@ | |||
| "operatingsystemrelease": [ | |||
| "18" | |||
| ] | |||
| }, | |||
| { | |||
| "operatingsystem": "FreeBSD, | |||
There was a problem hiding this comment.
please add the missing " and fix the alignment in the lines below (I highly recommend using soft tabs)
There was a problem hiding this comment.
Hi, my bad. The editor decided to insert some quotes by itself which I overlooked. Should be ok now. Hard tabs are gone too
|
Ok this seems to trigger additional errors, I’m looking into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This adds support for FreeBSD, using telegraf as installed by pkg(8).
Where applicable, spec logic from Darwin support was used.
FreeBSD's telegraf is in the package collection and needs no repository management.
This Pull Request (PR) fixes the following issues
n/a