Make log rotation configurable #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 28, 2023 16:28
bastelfreak
reviewed
Jun 28, 2023
Comment on lines
+115
to
+117
| $logfile_rotation_interval = '0h' | ||
| $logfile_rotation_max_size = '0MB' | ||
| $logfile_rotation_max_archives = 5 |
There was a problem hiding this comment.
Instead of adding the data here, please directly assign it in the init.pp. That enables puppet-strings to pick it up.
There was a problem hiding this comment.
Not sure that is the best way, I did it this way to be 100% consistent with the existing code, e.g. logfile.
In fact all values in init.pp reference telegraf::params
There was a problem hiding this comment.
yes it's the best way :) That's the standard we defined at https://voxpupuli.org/docs/reviewing_pr/ and we need to migrate the modules. We don't want more technical debt.
bastelfreak
reviewed
Jun 28, 2023
Comment on lines
+5
to
+7
| telegraf::logfile_rotation_interval: "0h" | ||
| telegraf::logfile_rotation_max_size: "0MB" | ||
| telegraf::logfile_rotation_max_archives: 5 |
There was a problem hiding this comment.
adding this should not be required
kenyon
changed the title
This was referenced Jul 3, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add log rotation parameters
This Pull Request (PR) fixes the following issues
Replaces pull request #149
Rebased the module using v5.0.0
Adding agent parameters:
logfile_rotation_interval, default = "0h"
logfile_rotation_max_size, default = "0MB"
logfile_rotation_max_archives, default = 5
I have added test data, setting these values to their default values.
Tested with bundle exec rake beaker - no errors
Tested in my environment on CentOS7, Ubuntu 18.04 & Windows 2019 - I just tested that the telegaf.conf file was updated appropriately