Provide the ability to disable or stop the telegraf service. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There may be a time when a sys admin needs to stop the telegraf service on one or more machines. Let's add the ability to _control_ the service, rather than statically enabling and starting the service.
yankcrime
reviewed
Feb 28, 2017
manifests/install.pp
Outdated
| @@ -28,7 +28,7 @@ | |||
| yumrepo { 'influxdata': | |||
| descr => "InfluxData Repository - ${::operatingsystem} \$releasever", | |||
| enabled => 1, | |||
| baseurl => "https://repos.influxdata.com/${_operatingsystem}/\$releasever/\$basearch/${::telegraf::repo_type}", | |||
| baseurl => "https://repos.influxdata.com/rhel\$releasever/\$basearch/${::telegraf::repo_type}", | |||
There was a problem hiding this comment.
If this is actually a problem, can you raise a separate PR for this change?
Joshua-Snapp
force-pushed
the
service_parameters
branch
from
95d8ac9
to
1aca025
Compare
|
@yankcrime I moved that change for the RHEL repo url to a separate PR. Let me know if there's anything else you'd like to see changed. |
|
Thanks @Joshua-Snapp ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be a time when a sys admin needs to stop the telegraf service
on one or more machines. Let's add the ability to control the
service, rather than statically enabling and starting the service.
Thanks for your work on this Puppet module!