replace toml templates with toml-rb gem #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @nrdmn - this looks like the most sensible way forward. I'll see about fixing those tests, and then this would be ideal for v2.0 of the module. |
|
There's some functionality that we require (like having multiple inputs of the same type in hiera) that I am working on adding. It looks like this PR solves that and much more. Looking forward to seeing this in a new version. |
|
@nrdmn I created a PR for your branch that may fix the spec tests and also added plugin_type through hiera so we can have the same input/output multiple times. |
|
The ball is in @nrdmn's court. I issued a pull request to his repo. |
Fixed hiera example, added precision and plugin_type for hiera
|
Thanks both! |
yankcrime
approved these changes
Jan 17, 2018
This was referenced Jan 17, 2018
Closed
sparr
reviewed
Jan 18, 2018
| }, | ||
| inputs => { | ||
| 'cpu' => { | ||
| 'cpu' => [{ |
sparr
referenced
this pull request
in hotschedules/puppet-telegraf
Jan 18, 2018
yankcrime
added a commit
that referenced
this pull request
Jan 19, 2018
yankcrime
added a commit
that referenced
this pull request
Jan 19, 2018
yankcrime
added a commit
that referenced
this pull request
Jan 19, 2018
This commit updates information related to version 2.0 of this module, including changes to the README. Puppet 4 is now the minimum version requirement. It explicitly states support for Ubuntu 16.04 as this is now the default SUT for acceptance testing. It also includes an unrelated but necessary fix called out by @sparr in PR #80.
Merged
Closed
sparr
pushed a commit
to hotschedules/puppet-telegraf
that referenced
this pull request
Jan 26, 2018
This commit updates information related to version 2.0 of this module, including changes to the README. Puppet 4 is now the minimum version requirement. It explicitly states support for Ubuntu 16.04 as this is now the default SUT for acceptance testing. It also includes an unrelated but necessary fix called out by @sparr in PR voxpupuli#80.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a real toml generator instead of templates.
It is an alternative approach to #47 and #79 and fixes #32, #38, #41, #42 and #68.
Tests are still mostly broken because I don't know ruby.