Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* fix: debian origins since archive name changes, moved to codename … #148

Merged

Conversation

Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

8 participants
@deubert-it
Copy link
Contributor

@deubert-it deubert-it commented Aug 15, 2019

…based filter for future proofing #145

Pull Request (PR) description

Debian changed apt repository archive names some weeks ago, this PR adapts the module to that and switches to codename (jessie/stretch/buster etc.) based origin filtering for debian based systems, so it should be more stable in the future.

This Pull Request (PR) fixes the following issues

Fixes #145

@drshawnkwang
Copy link

@drshawnkwang drshawnkwang commented Aug 16, 2019

Thank you for putting together this PR. I'm not a committer, just someone who noticed the bug. But I do have some Debian 8 and 9 servers, and I can go about testing this code. Hopefully I can find some time next week to do that.

@Scifire
Copy link

@Scifire Scifire commented Nov 19, 2019

Would say this is also related to #150, any reason why this is not merged?

@igalic
Copy link
Contributor

@igalic igalic commented Nov 19, 2019

any or all of

  • lack of volunteers
  • lack of volunteer time
  • "wrong" priorisation (of the above)
  • it was overlooked

@Scifire
Copy link

@Scifire Scifire commented Nov 19, 2019

@igalic well it was more like " I don´t see any open issues with this PR, maybe there is one which I didn´t see" ;-)

Copy link
Contributor

@igalic igalic left a comment

👀

manifests/params.pp Show resolved Hide resolved
spec/classes/debian_spec.rb Show resolved Hide resolved
@igalic
Copy link
Contributor

@igalic igalic commented Nov 19, 2019

@igalic well it was more like " I don´t see any open issues with this PR, maybe there is one which I didn´t see" ;-)

sometimes we get issues,
sometimes we get PRs,
sometimes we get both,
and sometimes we get neither.

(i'm feeling very poetical right now ;)

@anarcat
Copy link
Contributor

@anarcat anarcat commented Feb 6, 2020

we need this in our deployment so i'll likely merge this after another positive review.

thanks!

@anarcat anarcat mentioned this pull request Feb 6, 2020
@anarcat anarcat mentioned this pull request Feb 6, 2020
@hiromipaw
Copy link

@hiromipaw hiromipaw commented Feb 10, 2020

👍 This solve issue #145 making this module work also for newest version of debian. Would be nice to see this merged upstream in the near future.

@anarcat anarcat merged commit af3024e into voxpupuli:master Feb 10, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment