Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vault Namespaces #29

Merged
merged 5 commits into from Jun 30, 2022
Merged

Add support for Vault Namespaces #29

merged 5 commits into from Jun 30, 2022

Conversation

Augustin-FL
Copy link
Contributor

Pull Request (PR) description

This PR add support for Vault Namespaces.
It supersede #28

This Pull Request (PR) fixes the following issues

n/a

Copy link

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get a spec test for this?

@Augustin-FL
Copy link
Contributor Author

Sure! I'll make one

@vox-pupuli-tasks
Copy link

Dear @Augustin-FL, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@Augustin-FL
Copy link
Contributor Author

Augustin-FL commented Nov 21, 2020

Hi @igalic,

sorry for the delay. I added spec tests.

Could you have a look into what I've done? I'm quite new to rspec, so it may be not correct.

Also...for information the travis tests seems to be failing for everyone, it's not related to this PR.

Copy link

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i say we merge this, and see what happens

@Augustin-FL
Copy link
Contributor Author

@igalic do you have merge rights on this repo?

(as explained above, the tests are failing for everyone, it's not related to this PR)

@Augustin-FL
Copy link
Contributor Author

Hello @bastelfreak @pcarlisle @tvpartytonight,

Could you please merge this PR?

@vox-pupuli-tasks
Copy link

Dear @Augustin-FL, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

lib/puppet/functions/vault_lookup/lookup.rb Outdated Show resolved Hide resolved
lib/puppet/functions/vault_lookup/lookup.rb Outdated Show resolved Hide resolved
spec/functions/lookup_spec.rb Outdated Show resolved Hide resolved
@root-expert root-expert added enhancement New feature or request and removed tests-fail labels Jun 27, 2022
Augustin-FL and others added 3 commits June 28, 2022 00:20
Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
@bastelfreak
Copy link
Member

the next release (v0.3.0) is already quite big. I will release this now, then merge this PR and do a new release. In case this breaks something, people can still use v0.3.0. thanks for all the work!

@bastelfreak bastelfreak merged commit 2cfe5d9 into voxpupuli:master Jun 30, 2022
@Augustin-FL Augustin-FL deleted the patch-1 branch June 30, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants