New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Vault Namespaces #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get a spec test for this?
Sure! I'll make one |
Dear @Augustin-FL, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
Hi @igalic, sorry for the delay. I added spec tests. Could you have a look into what I've done? I'm quite new to rspec, so it may be not correct. Also...for information the travis tests seems to be failing for everyone, it's not related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i say we merge this, and see what happens
@igalic do you have merge rights on this repo? (as explained above, the tests are failing for everyone, it's not related to this PR) |
Hello @bastelfreak @pcarlisle @tvpartytonight, Could you please merge this PR? |
Dear @Augustin-FL, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
the next release (v0.3.0) is already quite big. I will release this now, then merge this PR and do a new release. In case this breaks something, people can still use v0.3.0. thanks for all the work! |
Pull Request (PR) description
This PR add support for Vault Namespaces.
It supersede #28
This Pull Request (PR) fixes the following issues
n/a