Update apt dependency #65
Conversation
Update apt module dependency to <5.0.0
|
@cdenneen Don't forget to repin |
puppetlabs-apt updated to 4.1.0
* puppetlabs-apt module deprecated old code with puppet 4 additions in 3.x Support for puppet <=3 was deprecated to apt module version 2.x * Updated apt dependency for fixtures and metadata.json * Updated spec tests for this
|
@razorsedge I've done a larger update. apt version 2.x was last supported version for Puppet 3. |
|
@cdenneen I appreciate the work you have put into this PR. Unfortunately, I do not find dropping support for Puppet 3 to be acceptable at this time. At least not until EPEL and various Long Term Support platforms stop shipping Puppet 3. |
|
@razorsedge Understood that's why I was recommending a new release of 7.x
that is a breaking change release. Between the apt dependency being 2
revisions behind, Puppet dropping all support and patches for <=3. I think
the 6.x release of your module will continue to work for anyone still using
Puppet 3. Anyone using Puppet 4 now (or even 5) and trying to stay up to
date with either of the last 2 major apt releases results in this being
completely broken and would have to use a self-maintained fork in order to
stay even remotely current. Most environments will be running modules that
now require apt >=3 so any sort of Puppetfile or puppet module install
would now have dependencies that can't be resolved.
This provides your users a legacy version to use while trying to stay
current.
There are a lot of Puppet 4 and 5 changes that can still be made to this
module but for now this was the minimum change in order to remove the
deprecated pieces.
Also I don't expect EPEL to be too far behind removing puppet 3 whenever
they get around to their next cleanup.
http://smoogespace.blogspot.com/2016/12/puppet-not-coming-back-to-epel-el-6.html?m=1
|
|
@razorsedge I've opened #66 to allow for Puppet3/4/5 to work and allow the dependency to be updated to 3.x.x or 4.x.x |
Update apt module dependency to <5.0.0