Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPuppet 6 issue and knockout_prefix problem #121
Conversation
avidspartan1
added some commits
Oct 1, 2018
avidspartan1
referenced this pull request
Oct 5, 2018
Open
--knock-out-prefix "--" knocks out valid content of yum::gpgkeys #111
This comment has been minimized.
This comment has been minimized.
jocelynthode
commented
Dec 11, 2018
|
I was able to bypass that when prefixing in my hiera file the yum::gpgkeys with "---" just above. Do we have an ETA on this PR being merged and a new version release @bastelfreak ? |
jeefberkey
approved these changes
Dec 19, 2018
bastelfreak
reviewed
Dec 26, 2018
| @@ -216,7 +216,7 @@ | |||
| true => '--keepdevel', | |||
| default => undef, | |||
| }, | |||
| ]) | |||
| ].filter |$val| { $val =~ NotUndef } | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hi, thanks for the PR.I'm not sure if this a breaking change or not. Could you explain a bit in which setup the old code break? Could you provide this as an acceptance test? |
bastelfreak
added
the
needs-feedback
label
Dec 26, 2018
This comment has been minimized.
This comment has been minimized.
avidspartan1
commented
Jan 2, 2019
|
The delete_undef_values code broke in an earlier version of Puppet 6--it looks like it was addressed in a later release. However, the knockout_prefix issue is still a problem. I'll try to find some time to update the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
avidspartan1 commentedOct 1, 2018
Pull Request (PR) description
This Pull Request (PR) fixes the following issues