New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppet 6 issue and knockout_prefix problem #121

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@avidspartan1
Copy link

avidspartan1 commented Oct 1, 2018

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@jocelynthode

This comment has been minimized.

Copy link

jocelynthode commented Dec 11, 2018

I was able to bypass that when prefixing in my hiera file the yum::gpgkeys with "---" just above.

Do we have an ETA on this PR being merged and a new version release @bastelfreak ?

@@ -216,7 +216,7 @@
true => '--keepdevel',
default => undef,
},
])
].filter |$val| { $val =~ NotUndef }

This comment has been minimized.

@bastelfreak

bastelfreak Dec 26, 2018

Member

oh nice, I didn't know that NotUndef is a thing!

@bastelfreak

This comment has been minimized.

Copy link
Member

bastelfreak commented Dec 26, 2018

Hi, thanks for the PR.I'm not sure if this a breaking change or not. Could you explain a bit in which setup the old code break? Could you provide this as an acceptance test?

@avidspartan1

This comment has been minimized.

Copy link

avidspartan1 commented Jan 2, 2019

The delete_undef_values code broke in an earlier version of Puppet 6--it looks like it was addressed in a later release. However, the knockout_prefix issue is still a problem. I'll try to find some time to update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment