Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppet 6 issue and knockout_prefix problem #121

Merged
merged 2 commits into from Mar 16, 2019

Conversation

@avidspartan1
Copy link

@avidspartan1 avidspartan1 commented Oct 1, 2018

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@jocelynthode
Copy link

@jocelynthode jocelynthode commented Dec 11, 2018

I was able to bypass that when prefixing in my hiera file the yum::gpgkeys with "---" just above.

Do we have an ETA on this PR being merged and a new version release @bastelfreak ?

@@ -216,7 +216,7 @@
true => '--keepdevel',
default => undef,
},
])
].filter |$val| { $val =~ NotUndef }

This comment has been minimized.

@bastelfreak

bastelfreak Dec 26, 2018
Member

oh nice, I didn't know that NotUndef is a thing!

This comment has been minimized.

@TJM

TJM Mar 16, 2019

er, maybe I am just mis-reading this, but wouldn't it have been easier to just set the default for $keep_kernel_devel to '' (empty string)? That is the only potentially undefined value there, right?

@bastelfreak
Copy link
Member

@bastelfreak bastelfreak commented Dec 26, 2018

Hi, thanks for the PR.I'm not sure if this a breaking change or not. Could you explain a bit in which setup the old code break? Could you provide this as an acceptance test?

@avidspartan1
Copy link
Author

@avidspartan1 avidspartan1 commented Jan 2, 2019

The delete_undef_values code broke in an earlier version of Puppet 6--it looks like it was addressed in a later release. However, the knockout_prefix issue is still a problem. I'll try to find some time to update the PR.

@a-zen
Copy link

@a-zen a-zen commented Feb 17, 2019

I'm facing the same issue by simply using the yum module without any configuration on a clean centos7 system. The patch from @bastelfreak fixes the issue.

@TJM
Copy link

@TJM TJM commented Mar 15, 2019

I am glad you have this fixed already, cause I was just about to dig into this one, and it was making me dizzy already. :)

@bastelfreak bastelfreak added bug and removed needs-feedback labels Mar 16, 2019
@bastelfreak bastelfreak merged commit 3f35c56 into voxpupuli:master Mar 16, 2019
2 checks passed
2 checks passed
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@larsnaesbye
Copy link

@larsnaesbye larsnaesbye commented Apr 23, 2019

Great! :-) Shouldn't this warrant a release? I don't mind patching locally, but it'd be easier to upgrade the module since Puppet 6 still acts up with 3.1.1.

@dgoldsmith
Copy link

@dgoldsmith dgoldsmith commented May 7, 2019

PR #121 may have been merged on 3/16/2019 but no new release tags have been published since then. Version 3.1.1 is still the latest tagged release and it does not include the gpgkeys knockout prefix fix.

@bastelfreak
Copy link
Member

@bastelfreak bastelfreak commented May 7, 2019

I'm doing a new release at #134

@dgoldsmith
Copy link

@dgoldsmith dgoldsmith commented May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants