add 'VirtuozzoLinux' support #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kBite
force-pushed
the
add-virtuozzolinux
branch
from
b531435
to
008151d
Compare
bastelfreak
reviewed
Oct 28, 2019
data/os/RedHat/VirtuozzoLinux.yaml
Outdated
| # VirtuozzoLinux default repos for AWS. | ||
| --- | ||
| yum::os_default_repos: | ||
| - "rhui-REGION-rhel-server-releases" |
There was a problem hiding this comment.
Can you have a look at the CentOS.yaml? I think the default repositories here are not correct for VirtuozzoLinux.
There was a problem hiding this comment.
I re-checked init.pp. To my understanding, these files would only be necessary if someone uses manage_os_default_repos = true. This would not work with the current version of this module. So I'd expect noone is actually using this.
If this is correct, implementing correct VirtuozzoLinux.yaml. VirtuozzoLinux/6.yaml, and VirtuozzoLinux/7.yaml would not be worth the time.
(I tried it. 6 and 7 only share two repo file names, everything else is different)
kBite
force-pushed
the
add-virtuozzolinux
branch
from
008151d
to
ce6f0c2
Compare
|
If you would like help on where to put the data, please post the contents of the default yum.repos.d files from each OS. Leaving the data out entirely is better than having it wrong, but if possible, it should be populated. IMO |
|
VirtuozzoLinux 7 |
|
VirtuozzoLinux 6 |
|
So, they are really close to being the same, but it is not simply 6 vs 7. The base repo name is different (although that wouldn't be too hard to work around), and the server name is different, but they are actually the same host. So, it is very much like the CentOS configuration (more like CentOS than RHEL). You can probably put each list of repos into the You basically should be able to (re)move all the files in /etc/yum.repos.d and puppet should create them and end up with the same end state (note that the yum type will actually create one file (xyz.repo) instead of putting them all into virtuozzo.repo, but the end result is the same. ~tommy PS: More importantly, some people (me) like to purge any unmanaged repos, so having a list of OS defaults is a "good thing" if you are going to add that to the supported list. :) |
bastelfreak
added
enhancement
kBite
force-pushed
the
add-virtuozzolinux
branch
from
ce6f0c2
to
477c94c
Compare
|
kBite
force-pushed
the
add-virtuozzolinux
branch
from
477c94c
to
020ba83
Compare
|
I've added all default repositories, but haven't tried de-duplicating anything. Does anyone have suggestions regarding de-duplication? Or is it ok the way it is as the data is not expected to change ever again. |
|
I've added tests, too. Now Travis shouldn't be failing anymore. Can someone please have a look? |
kBite
force-pushed
the
add-virtuozzolinux
branch
from
e74062e
to
daa619e
Compare
kBite
force-pushed
the
add-virtuozzolinux
branch
from
daa619e
to
791d55f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facter3.14 adds support foros.nameVirtuozzoLinux (https://puppet.com/docs/puppet/latest/release_notes_facter.html). This meansos.namewon't resolve to RedHat anymore.