Improve extraction of available updates #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vchepkov, can you please confirm that this fix your problem? |
vchepkov
approved these changes
Jun 5, 2020
|
thanks for the PR. can you add an acceptance test that verifies your changes are correct? The regex is quite hard to read :) |
smortex
force-pushed
the
improve-list-updates
branch
from
eccc3e2
to
e649f83
Compare
The `yum list updates` command outputs diagnostic messages and then the
actual available updates both on stdout. Depending on the installed yum
plugins, a variable number of diagnostic lines are emitted, and the
output is always formatted for humans, making it non-trivial to
distinguish useless and relevant lines.
Instead of ignoring the first line, match each line with a pattern
matching the following fields:
- package: The name of the package for which an update is available,
they are in the format <package-name>.<architecture>;
- available_version: The version of the package available for update,
ensure it starts with a digit;
- repository: The repository containing the update
These fields are separated by a variable amount of space. When a line
match this pattern, consider the package as relevant for update.
smortex
force-pushed
the
improve-list-updates
branch
from
e649f83
to
565e91c
Compare
|
I could finally managed to get some time for this. I added a few unit test and rebased the fix on top of master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The
yum list updatescommand outputs diagnostic messages and then the actual available updates both on stdout. Depending on the installed yum plugins, a variable number of diagnostic lines are emitted, and the output is always formatted for humans, making it non-trivial to distinguish useless and relevant lines.Instead of ignoring the first line, match each line with a pattern matching the following fields:
<package-name>.<architecture>;These fields are separated by a variable amount of space. When a line match this pattern, consider the package as relevant for update.
This Pull Request (PR) fixes the following issues
Fixes #180