CentOS 8 has been archived #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Feb 7, 2022
| gpgcheck: true | ||
| gpgkey: "file:///etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial" | ||
| target: '/etc/yum.repos.d/CentOS-AppStream.repo' | ||
| target: '/etc/yum.repos.d/CentOS-Linux-AppStream.repo' |
There was a problem hiding this comment.
is it a breaking change if we change the target? the old files could still exist and then we've the repo declared twice?
There was a problem hiding this comment.
It is not, since this parameter is still not handled properly by yumrepo resource in any puppet versions
https://tickets.puppetlabs.com/browse/MODULES-7422
But, this is the state where the final Centos update is in
$ rpm -qf /etc/yum.repos.d/CentOS-Linux-AppStream.repo
centos-linux-repos-8-3.el8.noarch
bastelfreak
approved these changes
Feb 7, 2022
|
Seems I have permissions to merge, but since I never done it before want to make sure don't do it out of turn :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
CentOS 8 has been archived