Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Puppet 4, remove support for Puppet 3 #25

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

lamawithonel
Copy link

This commit updates the module to better utilize the features of Puppet
4. In so doing, it removes support for older versions of Puppet.
Namely, this commit makes the following changes:

  • Adds spec tests for most components.
  • Use Puppet 4 type hinting for all parameter lists
  • Remove the params class, move static defaults, and configure
    in-module Hiera data for automatic parameter lookup.

@rnelson0
Copy link
Member

rnelson0 commented Jan 9, 2017

Thank you! This is exciting, I think it's the first VP module to drop puppet 3 support!

You will need to update metadata.json and .travis.yml to remove Puppet 3 support. Please put the travis settings in a separate commit as this would likely be the prototype for a modulesync_configs update.

There are also some rubocop failures that need remediated.

@rnelson0
Copy link
Member

rnelson0 commented Jan 9, 2017

Note: Before merging, a puppet3 branch should be created.

@rnelson0
Copy link
Member

@lamawithonel bump. Can I do anything to help you here?

@lamawithonel
Copy link
Author

Yes, I've fixed the Rubocop stuff. Spotted a few things I missed and I'm working on those now.

@bastelfreak
Copy link
Member

hey @lamawithonel, thanks for the awesome PR. Can you please rebase against master? We turned it puppet4 only now, this will shrink the travis matrix. Also we pushed an update to our rubocop conf which should lower the failures in this PR. Do you know that rubocop has an autofix option which sometimes/often works? Let us know if you need any help.

bundle exec rubocop -c .rubocop.yml -D -S -a

@lamawithonel lamawithonel force-pushed the puppet_4 branch 2 times, most recently from c7ccb21 to befd9a8 Compare January 11, 2017 23:49
This commit updates the module to better utilize the features of Puppet
4.  In so doing, it removes support for older versions of Puppet.
Namely, this commit makes the following changes:

 * Adds spec tests for most components.
 * Use Puppet 4 type hinting for all parameter lists
 * Remove the params class, move static defaults, and configure
    in-module Hiera data for automatic parameter lookup.
@lamawithonel
Copy link
Author

Everything's been updated.

@bastelfreak
Copy link
Member

thanks!

@bastelfreak bastelfreak merged commit d14dddf into voxpupuli:master Jan 13, 2017
@bastelfreak bastelfreak added the enhancement New feature or request label Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants